Fix TypeError in exponential_delay function when handling connection timeouts #125
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timeouts Problem: - Agent v1.8.3-1~noble crashes on Ubuntu 24.04 with TypeError when receiver.amplify.nginx.com times out - Error occurs in backoff.py: "TypeError: 'float' object cannot be interpreted as an integer" - The issue prevents proper exponential backoff during network connectivity problems - Agent completely stops instead of retrying with the backoff delay Solution: - Add explicit integer type conversion to period_size before passing to randint() - Convert: return randint(0, period_size - 1) - To: return randint(0, int(period_size) - 1) This fix allows the agent to properly handle connection timeouts without crashing. The issue appears to be specific to Python 3.12 used in Ubuntu 24.04 Noble, as the agent works correctly on Ubuntu 22.04 Jammy with Python 3.10. Fixes nginxinc#124
jasil1414
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the NGINX Amplify Agent v1.8.3-1 crashes when experiencing connection timeouts to receiver.amplify.nginx.com on Ubuntu 24.04 Noble. The root cause is a TypeError in the exponential_delay function where a float value is being passed to random.randint() which requires integer arguments.
Environment
Issue
When a connection timeout occurs, the agent attempts to use the exponential backoff mechanism, but crashes with:
TypeError: 'float' object cannot be interpreted as an integerThis causes the agent to completely stop instead of properly handling the timeout and retrying later.
Fix
The fix is a simple type conversion to ensure an integer is passed to the randint() function: