Skip to content

Conform colors into better var names #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Conform colors into better var names #237

merged 3 commits into from
May 15, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Apr 25, 2025 •
edited
Loading

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/469 and https://github.com/nginxinc/docs-platform/issues/467

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added enhancement New feature or request cleanup labels Apr 25, 2025
@lamATnginx lamATnginx self-assigned this Apr 25, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 25, 2025 19:45
@lamATnginx lamATnginx marked this pull request as draft April 25, 2025 19:45
@lamATnginx lamATnginx force-pushed the chore/sem-color-names branch 2 times, most recently from 5c94523 to 99d13b9 Compare May 2, 2025 19:47
@lamATnginx
Copy link
Collaborator Author

Used this as main resource: https://medium.com/@brcsndr/you-dont-know-css-design-tokens-naming-structure-52add5d02682

@lamATnginx lamATnginx force-pushed the chore/sem-color-names branch 3 times, most recently from 230ea53 to 56b309e Compare May 5, 2025 17:56
@lamATnginx lamATnginx marked this pull request as ready for review May 7, 2025 16:36
nginx-jack
nginx-jack approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just resolve the conflicts 👌

@lamATnginx lamATnginx force-pushed the chore/sem-color-names branch from 56b309e to d86b0fa Compare May 15, 2025 17:51
@lamATnginx lamATnginx force-pushed the chore/sem-color-names branch from d86b0fa to f134ea1 Compare May 15, 2025 17:52
@lamATnginx lamATnginx force-pushed the chore/sem-color-names branch from f134ea1 to 91dc9a0 Compare May 15, 2025 17:56
@lamATnginx lamATnginx merged commit 50b53b6 into main May 15, 2025
7 checks passed
@lamATnginx lamATnginx mentioned this pull request May 15, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels
cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @nginx-jack