Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: updating naming conventions #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: updating naming conventions #48

wants to merge 1 commit into from

Conversation

f5yacobucci
Copy link
Contributor

Consistently use _ptr and _mut_ptr for our functions that return *mut and *const pointers.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@f5yacobucci
Copy link
Contributor Author

I did not update the Module trait function names, as these match 1:1 with the NGINX names I left them untouched and consistent with the C naming semantics.

@f5yacobucci
Copy link
Contributor Author

TODO: update README with a conventions section

@dekobon
Copy link
Contributor

dekobon commented May 2, 2024

@f5yacobucci Is this PR now obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanitskiy ivanitskiy Awaiting requested review from ivanitskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f5yacobucci @dekobon