feat: conditional compilation support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo fmt` already passes this option, but some editors prefer to call rustfmt directly.
nginx-sys cannot be used as rlib or as a static library.
bavshin-f5
force-pushed
the
ngx-feature-checks
branch
2 times, most recently
from
bf4e8f4
to
daf6dba
Compare
The example build script converts `DEP_NGINX_FEATURES`, `DEP_NGINX_OS` and `DEP_NGINX_VERSION_NUMBER` received from `nginx-sys` to the `cfg` values for conditional compilation. See tests for usage examples.
The flags set in cargo config will be ignored if the `RUSTFLAGS` is set.
Document cargo metadata variables set by the build script.
bavshin-f5
force-pushed
the
ngx-feature-checks
branch
from
daf6dba
to
3e57973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx has various configuration options that may affect the availability of functions, constants and structure fields. This is not something that can be detected at runtime, as an attempt to use a symbol unavailable in the bindings would result in compilation error.
This PR introduces translation of a limited subset of
NGX_...macros to the Rustcfgflags, allowing conditional checks like#[cfg(ngx_feature = "debug")].There's no publicly available code that uses these flags yet, but I already need the functionality for some WIP stuff.