feat: Add a default domain reclaim policy#656
Merged
jonstacks merged 1 commit intongrok:mainfrom May 16, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 30.73% 30.84% +0.11%
==========================================
Files 100 101 +1
Lines 15876 15919 +43
==========================================
+ Hits 4879 4911 +32
- Misses 10710 10723 +13
+ Partials 287 285 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alice-Lilith
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #641 for more context
What
Now that Domains have a Reclaim Policy, we can set a default Domain Reclaim Policy for Domains created by the operator. It respects existing created domain CRs deletion policy. For example, if a domain CR was created manually with a Reclaim Policy of Retain, and the
defaultDomainReclaimPolicyis set to Delete, it will not overwrite the existing ReclaimPolicy of Retain.How
defaultDomainReclaimPolicyto the helm chartBreaking Changes
No. The current domain Reclaim Policy defaults to "Delete" and the
defaultDomainReclaimPolicymirrors this. We still do not delete Domain CRs when they drop out of scope of the driver.