fix(signals): patch state methods do not correctly resolve generic co…#4646
Closed
ivashikhmin wants to merge 1 commit intongrx:mainfrom
Closed
fix(signals): patch state methods do not correctly resolve generic co…#4646ivashikhmin wants to merge 1 commit intongrx:mainfrom
ivashikhmin wants to merge 1 commit intongrx:mainfrom
Conversation
…llection names withEntities Ensures type-safety of named entity collections with patchState helpers fixes ngrx#4638
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
Comment on lines
+13
to
+19
| export type NamedEntityState<Entity, Collection extends string> = Prettify< | ||
| { | ||
| [K in `${Collection}EntityMap`]: EntityMap<Entity>; | ||
| } & { | ||
| [K in `${Collection}Ids`]: EntityId[]; | ||
| } | ||
| >; |
Member
There was a problem hiding this comment.
I'm not a big fan of this approach because we will have to keep this in sync with the EntityMap entity. To be honest, I'm also not sure why this works and adding Prettify around the current type doesn't.
Another solution is to change the signature of PartialStateUpdater, and wrap the State with Prettify:
export type PartialStateUpdater<State extends object> = (
state: Prettify<State>
) => Partial<State>;
Member
|
We'll take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llection names withEntities
Ensures type-safety of named entity collections with patchState helpers
fixes #4638
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4638
What is the new behavior?
Collection extends stringgeneric could be used to make features with named entity collections (withEntities) and state updaters, e.g. addEntity, in type-safe manner and allow method naming like inngrx-toolkit withDataService
Does this PR introduce a breaking change?