Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental misuse of Sonar token #109

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

stefaniuk
Copy link
Contributor

@stefaniuk stefaniuk commented Aug 24, 2023

Description

Prevent accidental misuse of Sonar token by forcing to store organisation key and project key as GitHub secrets.

Context

Sonar token is a user token.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Contributor

@jacobgill1 jacobgill1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've just left the one question.

Copy link
Contributor

@jacobgill1 jacobgill1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefaniuk stefaniuk added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit ded0ef9 Aug 24, 2023
36 checks passed
@stefaniuk stefaniuk deleted the Sonar_tokens_are_user_tokens branch August 24, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarCloud doesn't seem to validate token against org and project name
2 participants