Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scan dependencies git hook #132

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

stefaniuk
Copy link
Contributor

Description

There is not much benefit in running a potentially outdated CVE check locally, especially considering that the GitHub Action always performs a check against the latest version.

Context

Grype updates its database at the first run or every 5 days. The size is approximately 1GB. It may take minutes for the scan dependencies git hook to complete. This is not a good user experience.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@regularfry
Copy link
Contributor

Yep, that looks good. I was wondering whether we ought to keep the wrapper script, but it's not hard to recreate if we want it again in future.

@stefaniuk stefaniuk added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 2ba6d0d Sep 21, 2023
35 checks passed
@stefaniuk stefaniuk deleted the Remove_scan_dependencies_git_hook branch September 21, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.git/hooks/pre-commit is far too slow
2 participants