Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the _install-dependencies task and call it from make config #144

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

regularfry
Copy link
Contributor

Description

This adds the make _install-dependencies task, which installs everything from the .tool-versions file.

Context

This avoids the need to add a new make task for each dependency, instead treating the .tool-versions file as canonical. Specifically it avoids the need for the user to add a make _install-python task in the tutorial.

For discussion: do we still need make _install-terraform if we have this? I don't think we do.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Contributor

@stefaniuk stefaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefaniuk stefaniuk added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit c869280 Nov 21, 2023
35 checks passed
@stefaniuk stefaniuk deleted the make-install-deps branch November 21, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants