-
Notifications
You must be signed in to change notification settings - Fork 0
[PRMT-466] Create alarm for old messages in the queue #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # infrastructure/README.md
infrastructure/sqs_alarms.tf
Outdated
}) | ||
} | ||
|
||
resource "aws_cloudwatch_metric_alarm" "sqs_oldest_message_alarm" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource "aws_cloudwatch_metric_alarm" "sqs_oldest_message_alarm" { | |
resource "aws_cloudwatch_metric_alarm" "sqs_oldest_message" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
infrastructure/sqs_alarms.tf
Outdated
Workspace = terraform.workspace | ||
} | ||
} | ||
resource "aws_sns_topic_subscription" "global_sqs_alarm_subscriptions" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource "aws_sns_topic_subscription" "global_sqs_alarm_subscriptions" { | |
resource "aws_sns_topic_subscription" "sqs_oldest_message_alarm" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got confused here,
Should it be sqs_oldest_message_alarm, or sqs_oldest_message, considering on line 53 it changed from sqs_oldest_message_alarm to sqs_oldest_message
Report for environment: ndr-devTerraform Initialization ⚙️
|
# TODO: Delete is_test_sandbox, and change all call of is_test_sandbox to is_sandbox | ||
|
||
module "global_sqs_age_alarm_topic" { | ||
count = local.is_test_sandbox ? 0 : 1 # TODO:change is_test_sandbox to is_sandbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to change before merge.
Create an alarm for when messages are in the queue for 6 days
https://nhsd-jira.digital.nhs.uk/browse/PRMT-466