-
Notifications
You must be signed in to change notification settings - Fork 0
[NDR-74] Variable Types & Descriptions #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
variable "web_acl_id" { | ||
description = "Web ACL to associate this Cloudfront distribution with." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Web ACL to associate this Cloudfront distribution with." | |
description = "Web ACL to associate this CloudFront distribution with." |
} | ||
|
||
variable "owner" { | ||
type = string | ||
description = "Identifies the team or person responsible for the resource (used for tagging)." | ||
type = string | ||
} | ||
|
||
variable "current_account_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this not be obtained within the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticket raised NDR-181
@@ -1,45 +1,55 @@ | |||
variable "current_account_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be discovered within the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticket raised NDR-181
type = string | ||
} | ||
|
||
variable "table_name" { | ||
description = "The name of the bucket" | ||
description = "The name of the DynamoDB table used by the Lambda function." | ||
type = string | ||
} | ||
|
||
variable "current_account_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be discovered within the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticket raised NDR-181
} | ||
variable "enable_fifo" { | ||
description = "Attach first in first out policy to notification queue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Attach first in first out policy to notification queue" | |
description = "Attach first in first out policy to notification queue." |
} | ||
|
||
variable "enable_deduplication" { | ||
description = "Prevent content based duplication in notification queue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Prevent content based duplication in notification queue" | |
description = "Prevent content based duplication in notification queue." |
default = [] | ||
description = "A list of endpoints (e.g., SQS ARNs) to subscribe to the topic." | ||
type = any | ||
default = [] | ||
} | ||
|
||
variable "current_account_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be discovered within the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticket raised NDR-181
@@ -39,15 +40,15 @@ variable "enable_sse" { | |||
} | |||
|
|||
variable "enable_deduplication" { | |||
description = "Prevent content based duplication in queue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Prevent content based duplication in queue" | |
description = "Prevent content based duplication in queue." |
} | ||
|
||
variable "enable_fifo" { | ||
description = "Attach first in first out policy to sqs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Attach first in first out policy to sqs" | |
description = "Attach 'first in first out' policy to SQS queue." |
@@ -57,18 +58,21 @@ variable "kms_master_key_id" { | |||
} | |||
|
|||
variable "max_receive_count" { | |||
type = number | |||
default = 1 | |||
description = "Maximum number of receives before messages are moved to the DLQ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Maximum number of receives before messages are moved to the DLQ." | |
description = "Maximum number of receives before messages are moved to the dead-letter queue." |
} | ||
|
||
output "endpoint" { | ||
value = aws_sqs_queue.sqs_queue.arn | ||
description = "Same as sqs queue arn. For use when setting the queue as endpoint of sns topic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Same as sqs queue arn. For use when setting the queue as endpoint of sns topic" | |
description = "The SQS queue ARN e.g. for use when setting the queue as the endpoint of an SNS topic." |
@@ -112,4 +118,4 @@ output "sqs_write_policy_document" { | |||
} | |||
output "dlq_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs description?
@@ -1,80 +1,88 @@ | |||
# Availability zones for Amazon region | |||
variable "standalone_vpc_tag" { | |||
type = string | |||
description = "This is the tag assigned to the standalone vpc that should be created manaully before the first run of the infrastructure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "This is the tag assigned to the standalone vpc that should be created manaully before the first run of the infrastructure" | |
description = "This is the tag assigned to the standalone VPC that should be created manually before the first run of the infrastructure." |
} | ||
|
||
variable "standalone_vpc_ig_tag" { | ||
type = string | ||
description = "This is the tag assigned to the standalone vpc internet gateway that should be created manaully before the first run of the infrastructure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "This is the tag assigned to the standalone vpc internet gateway that should be created manaully before the first run of the infrastructure" | |
description = "This is the tag assigned to the standalone VPC internet gateway that should be created manually before the first run of the infrastructure." |
} | ||
|
||
variable "availability_zones" { | ||
type = list(string) | ||
description = "This is a list that specifies all the Availability Zones that will have a pair of public and private subnets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "This is a list that specifies all the Availability Zones that will have a pair of public and private subnets" | |
description = "This list specifies all the Availability Zones that will have a pair of public and private subnets." |
infrastructure/variable.tf
Outdated
default = "api-" | ||
} | ||
|
||
# Bucket Variables | ||
variable "docstore_bucket_name" { | ||
type = string | ||
description = "The name of the S3 bucket to store ARF documents" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the S3 bucket to store ARF documents" | |
description = "The name of the S3 bucket to store ARF documents." |
infrastructure/variable.tf
Outdated
default = "statistical-reports" | ||
} | ||
|
||
# DynamoDB Table Variables | ||
|
||
variable "pdm_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to be use for pdm metadata." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to be use for pdm metadata." | |
description = "The name of the DynamoDB table to be use for PDM metadata." |
infrastructure/variable.tf
Outdated
default = "PDMDocumentMetadata" | ||
} | ||
|
||
variable "docstore_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store the metadata of ARF documents." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the metadata of ARF documents." | |
description = "The name of the DynamoDB table to store the metadata of ARF documents." |
infrastructure/variable.tf
Outdated
default = "DocumentReferenceMetadata" | ||
} | ||
|
||
variable "lloyd_george_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store the metadata of Lloyd George documents." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the metadata of Lloyd George documents." | |
description = "The name of the DynamoDB table to store the metadata of Lloyd George documents." |
infrastructure/variable.tf
Outdated
default = "LloydGeorgeReferenceMetadata" | ||
} | ||
|
||
variable "unstitched_lloyd_george_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store the metadata of un-stitched Lloyd George documents." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the metadata of un-stitched Lloyd George documents." | |
description = "The name of the DynamoDB table to store the metadata of un-stitched Lloyd George documents." |
infrastructure/variable.tf
Outdated
default = "UnstitchedLloydGeorgeReferenceMetadata" | ||
} | ||
|
||
variable "cloudfront_edge_table_name" { | ||
description = "The name of the dynamodb table to store the presigned url reference of CloudFront requests." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the presigned url reference of CloudFront requests." | |
description = "The name of the DynamoDB table to store the presigned URL reference of CloudFront requests." |
infrastructure/variable.tf
Outdated
default = "CloudFrontEdgeReference" | ||
} | ||
|
||
variable "zip_store_dynamodb_table_name" { | ||
type = string | ||
default = "ZipStoreReferenceMetadata" | ||
description = "The name of the dynamodb table to store metadata related to zip file storage." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store metadata related to zip file storage." | |
description = "The name of the DynamoDB table to store metadata related to zip file storage." |
infrastructure/variable.tf
Outdated
} | ||
|
||
variable "stitch_metadata_dynamodb_table_name" { | ||
type = string | ||
default = "LloydGeorgeStitchJobMetadata" | ||
description = "The name of the dynamodb table to store metadata related to LG stitching jobs ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store metadata related to LG stitching jobs ." | |
description = "The name of the DynamoDB table to store metadata related to Lloyd George stitching jobs." |
infrastructure/variable.tf
Outdated
} | ||
|
||
variable "auth_state_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store the state values (for CIS2 authorisation)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the state values (for CIS2 authorisation)." | |
description = "The name of the DynamoDB table to store the state values (for CIS2 authorisation)." |
infrastructure/variable.tf
Outdated
default = "AuthStateReferenceMetadata" | ||
} | ||
|
||
variable "auth_session_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store user login sessions." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store user login sessions." | |
description = "The name of the DynamoDB table to store user login sessions." |
infrastructure/variable.tf
Outdated
default = "AuthSessionReferenceMetadata" | ||
} | ||
|
||
variable "bulk_upload_report_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store bulk upload status." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store bulk upload status." | |
description = "The name of the DynamoDB table to store bulk upload status." |
infrastructure/variable.tf
Outdated
default = "BulkUploadReport" | ||
} | ||
|
||
variable "statistics_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store application statistics." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store application statistics." | |
description = "The name of the DynamoDB table to store application statistics." |
infrastructure/variable.tf
Outdated
default = "ApplicationStatistics" | ||
} | ||
|
||
variable "access_audit_dynamodb_table_name" { | ||
description = "The name of the dynamodb table to store the audit of access to deceased patient records." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the audit of access to deceased patient records." | |
description = "The name of the DynamoDB table to store the audit of access to deceased patient records." |
infrastructure/variable.tf
Outdated
default = "AccessAudit" | ||
} | ||
|
||
variable "alarm_state_history_table_name" { | ||
type = string | ||
description = "The name of the dynamodb table to store the history of recent alarms that have been triggered." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "The name of the dynamodb table to store the history of recent alarms that have been triggered." | |
description = "The name of the DynamoDB table to store the history of recent alarms that have been triggered." |
infrastructure/variable.tf
Outdated
default = "AlarmStateHistory" | ||
} | ||
|
||
# VPC Variables | ||
|
||
variable "standalone_vpc_tag" { | ||
description = "This is the tag assigned to the standalone vpc that should be created manaully before the first run of the infrastructure." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "This is the tag assigned to the standalone vpc that should be created manaully before the first run of the infrastructure." | |
description = "This is the tag assigned to the standalone VPC that should be created manually before the first run of the infrastructure." |
infrastructure/variable.tf
Outdated
} | ||
|
||
variable "standalone_vpc_ig_tag" { | ||
description = "This is the tag assigned to the standalone vpc internet gateway that should be created manaully before the first run of the infrastructure." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "This is the tag assigned to the standalone vpc internet gateway that should be created manaully before the first run of the infrastructure." | |
description = "This is the tag assigned to the standalone VPC internet gateway that should be created manaully before the first run of the infrastructure." |
infrastructure/variable.tf
Outdated
default = false | ||
} | ||
|
||
variable "enable_dns_support" { | ||
description = "Enable DNS support for VPC." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Enable DNS support for VPC." | |
description = "Enable DNS support for VPC." |
variable "cloudwatch_alarm_evaluation_periods" {} | ||
|
||
variable "apim_environment" {} | ||
variable "apim_environment" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan shows the following warnings... do they need fixing?
The root module does not declare a variable named "poll_frequency" but a
value was found in file "***". If you meant to use this value, add a
"variable" block to the configuration.
The root module does not declare a variable named
"cloudwatch_alarm_evaluation_periods" but a value was found in file
"***". If you meant to use this value, add a "variable" block to the
configuration.
} | ||
|
||
variable "cloudfront_arn" { | ||
description = "CloudFront Distribution ARN association and policy toggles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "CloudFront Distribution ARN association and policy toggles" | |
description = "Cloudfront distribution ARN association and policy toggles" |
Report for environment: ndr-devTerraform Initialization ⚙️
|
No description provided.