Skip to content

Enabling enum flags plugin changes #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rahulr-NI
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Support Enum flags with type ViUInt64

List issues fixed by this Pull Request below, if any.

What testing has been done?

Ensure that there are no failures in tox build.

@rahulr-NI rahulr-NI changed the title Enabling Enum Flags plugin changes Enabling enum flags plugin changes Jul 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.09%. Comparing base (a488e07) to head (3c88c9f).

Files with missing lines Patch % Lines
generated/nifake/nifake/_grpc_stub_interpreter.py 50.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (82.09%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (a488e07) and HEAD (3c88c9f). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (a488e07) HEAD (3c88c9f)
nifgensystemtests 1 0
niswitchsystemtests 1 0
niscopesystemtests 1 0
nisesystemtests 1 0
nimodinstsystemtests 1 0
nidmmsystemtests 1 0
nitclksystemtests 1 0
nidcpowersystemtests 1 0
nidigitalsystemtests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2114      +/-   ##
==========================================
- Coverage   91.24%   82.09%   -9.16%     
==========================================
  Files          67       29      -38     
  Lines       16386     4088   -12298     
==========================================
- Hits        14952     3356   -11596     
+ Misses       1434      732     -702     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests ?
nifakeunittests 86.81% <93.75%> (+0.09%) ⬆️
nifgensystemtests ?
nimodinstsystemtests ?
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests ?
niscopeunittests 43.20% <ø> (ø)
nisesystemtests ?
niswitchsystemtests ?
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nifake/nifake/_visatype.py 100.00% <100.00%> (ø)
generated/nifake/nifake/enums.py 100.00% <100.00%> (ø)
generated/nifake/nifake/session.py 80.42% <100.00%> (+0.21%) ⬆️
generated/nifake/nifake/_grpc_stub_interpreter.py 83.33% <50.00%> (-0.28%) ⬇️

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a488e07...3c88c9f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI marked this pull request as ready for review July 8, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants