feat(results): Update dependencies to load on initialization #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The current implementation does not update the dependency when initializing.
This pull request refines the logic for detecting and handling changes in
resultsQuery.👩💻 Implementation
loadStepPathsmethod inQueryStepsDataSourceby removing unused parameters and streamlining its implementation. (stepsPathinto the newvalidateAndUpdateStepPathsmethod, reducing redundancy across the codebase.onResultsFilterChangewithinQueryStepsEditorto ensure thathandleQueryChangeis triggered only whenresultsQuerydiffers from both the current and previous values.QueryStepsDataSourceto introducecurrentResultsQueryalongsidepreviousResultsQuery, and moved the logic for updatingstepsPathinto a newvalidateAndUpdateStepPathsmethod for better encapsulation and reusability.🧪 Testing
QueryStepsEditor.test.tsxto verify thatresultsQueryupdates correctly when it differs from the previous query.validateAndUpdateStepPathsinQueryStepsDataSource.test.tsto ensure it updatesstepsPathcorrectly whenresultsQuerychanges.✅ Checklist