Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give better error description on mautic install #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Give better error description on mautic install #48

wants to merge 3 commits into from

Conversation

pjrobertson
Copy link

fixes #47

@pjrobertson
Return more information on mautic version query
2974e6d 
Change to return a json obj (to be decoded by frontend javascript)
@pjrobertson
Give better error messages on mautic installation fail
7f304b8 
fixes nickian#47
Also: improve UI and form error checking
@pjrobertson
Break long lines in console
d9d2449 
(Allows you to see full paths in long error messages)
@pjrobertson
Copy link
Author

Turns out there were quite a few more bugs in here. Other things I've fixed:

  1. Previously, if you set the width of the sidebar logo to a very high number it'd crash/hang your computer (as the computer tried to blow up the image to a large size). Added in a check on the min/max values of this input
  2. Check the validity of the whole form before submitting it (to make sure all inputs are valid)
  3. Wrap text in the console, allowing you to see long errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better message when correct template version does not exist
1 participant
@pjrobertson