Skip to content

Remove unnecessary sudo from regex install command #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

nickspaargaren
Copy link
Owner

Context

Turns out the sudo command isn't necessary here. This PR removes this from the readme.

#207

How to test

Requirements

  • Docker

Setup new Pi-Hole test installation

  • Pull the Pi-hole docker image by running docker pull pihole/pihole:2024.07.0
  • Start the Pi-hole docker container by running docker run --name pihole -d -p 8080:80 -e WEBPASSWORD=admin pihole/pihole:2024.07.0
  • Navigate to http://localhost:8080/admin/
  • Login in with password admin and check "Remind me for 7 days"
  • Install Python inside the docker container by running docker exec pihole sh -c "sudo apt update && apt install python3 -y"

Import domains in Pi-Hole

@nickspaargaren nickspaargaren merged commit 93337bd into master Aug 2, 2024
3 checks passed
@nickspaargaren nickspaargaren deleted the update-readme-remove-sudo branch August 2, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant