Feature/fix dockerfile #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghasemim1999
suggested changes
Jan 11, 2025
docker/Dockerfile
Outdated
| pip3 install -r requirements.txt && \ | ||
| cp /pyhss/tools/Diameter_client.py /pyhss/ && \ | ||
| chmod +x *.sh | ||
| WORKDIR /pyhss |
There was a problem hiding this comment.
It's not! removed!
meghasemim1999
approved these changes
Jan 13, 2025
nickvsnetworking
merged commit 2598422
into
nickvsnetworking:master
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous dockerfile is obsolete and the project structure changed, so we need to update dockerfile which follows the new project structure and rules and is small in size.
The proposed docker file uses python-alpine as the base image to minimize its size. It also runs the minimum of what PyHSS can do (HSS, Diameter, and rest API) while it's easy to change and to run more services like metricService or georedService.