Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Address String Input in Google Router's Directions Method #126

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Jovillios
Copy link
Contributor

This pull request addresses an inconsistency between the documentation and the functionality of the Google router's directions method. While the documentation suggests that it's possible to provide an address string instead of coordinates or waypoints, the current implementation doesn't support this. However, the Google Maps API does allow address strings.

To resolve this, I've implemented support for address strings in the directions method of the Google router. This enhancement aligns the functionality with the expected behavior outlined in the documentation.

@chrstnbwnkl
Copy link
Contributor

thanks @Jovillios we haven't been updating the non open source routers, and are not really that interested in them anymore, but since this is just a small fix we'll go with it :)

@chrstnbwnkl chrstnbwnkl merged commit fd474a0 into nilsnolde:master Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants