Improve s390x CPU support #25056
Merged
Improve s390x CPU support #25056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushing the new csources would make it possible to build Nim on s390x without any tricks and manual edits, but I don't know how to re-generate the csources from the Nim repo. |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Sep 29, 2025
TODO list, copied from the documentation: - [x] compiler/platform.nim Add os/cpu properties. - [x] lib/system.nim Add os/cpu to the documentation for system.hostOS and system.hostCPU. - [x] ~~compiler/options.nim Add special os/cpu property checks in isDefined.~~ seems unnecessary; isn't dont for most CPUs - [x] compiler/installer.ini Add os/cpu to Project.Platforms field. - [x] lib/system/platforms.nim Add os/cpu. - [x] ~~std/private/osseps.nim Add os specializations.~~ - [x] ~~lib/pure/distros.nim Add os, package handler.~~ - [x] ~~tools/niminst/makefile.nimf Add os/cpu compiler/linker flags.~~ already done in #20943 - [x] tools/niminst/buildsh.nimf Add os/cpu compiler/linker flags. For csource: - [x] have compiler/platform.nim updated - [x] have compiler/installer.ini updated - [x] have tools/niminst/buildsh.nimf updated - [x] have tools/niminst/makefile.nimf updated - [ ] be backported to the Nim version used by the csources - [ ] the new csources must be pushed - [ ] the new csources revision must be updated in config/build_config.txt Additionally: - [x] check relation to #20943 Possible future work: - Porting Nim to s390x-specific operating systems, notably z/OS Co-authored-by: ringabout <[email protected]> (cherry picked from commit f4497c6)
Araq
pushed a commit
that referenced
this pull request
Oct 10, 2025
ref #25056 https://github.com/nim-lang/nightlies/actions/runs/18053288396/job/51378922406#step:12:1572 ``` bin/nim compile -f --incremental:off --compileonly --gen_mapping --cc:gcc --skipUserCfg --os:windows --cpu:loongarch64 -d:danger -d:gitHash:f4497c61584dca8acd489ceb7ba862b150f5cf55 compiler/nim.nim ``` `loongarch64` is applied to all the platforms wrongly. Presumably it was caused by the order?
narimiran
pushed a commit
that referenced
this pull request
Oct 13, 2025
ref #25056 https://github.com/nim-lang/nightlies/actions/runs/18053288396/job/51378922406#step:12:1572 ``` bin/nim compile -f --incremental:off --compileonly --gen_mapping --cc:gcc --skipUserCfg --os:windows --cpu:loongarch64 -d:danger -d:gitHash:f4497c61584dca8acd489ceb7ba862b150f5cf55 compiler/nim.nim ``` `loongarch64` is applied to all the platforms wrongly. Presumably it was caused by the order? (cherry picked from commit 3962264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO list, copied from the documentation:
compiler/options.nim Add special os/cpu property checks in isDefined.seems unnecessary; isn't dont for most CPUsstd/private/osseps.nim Add os specializations.lib/pure/distros.nim Add os, package handler.tools/niminst/makefile.nimf Add os/cpu compiler/linker flags.already done in Support IBM Z architecture #20943For csource:
Additionally:
Possible future work: