fix spawn not used on linux #25206
fix spawn not used on linux #25206
Conversation
|
|
||
| const useProcessAuxSpawn = declared(posix_spawn) and not defined(useFork) and | ||
| not defined(useClone) and not defined(linux) | ||
| not (defined(useClone) and defined(linux)) |
There was a problem hiding this comment.
| not (defined(useClone) and defined(linux)) | |
| not defined(useClone) |
| var dataCopy = data | ||
|
|
||
| when defined(useClone): | ||
| when defined(useClone) and defined(linux): |
There was a problem hiding this comment.
| when defined(useClone) and defined(linux): | |
| when defined(useClone): |
Assumption here is that useClone implies Linux because it's a linux specific call.
There was a problem hiding this comment.
This can lead to a bug in the current implementation, e.g. when useFork and useClone are defined, but we're not on linux.
There was a problem hiding this comment.
At the top of osproc.nim there is this:
when defined(linux) and defined(useClone):
import std/linuxSo I assumed it can happen that useClone is defined, but not linux. If this shouldn't happen, maybe an assertion should be added here, and useClone & linux check reduced to useClone?
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Subj, among other things slows down the compilation of large projects on linux significantly. (cherry picked from commit 440b55a)
2 participants
Subj, among other things slows down the compilation of large projects on linux significantly.