fixes #25205 #14873; resets importc obj with nimZeroMem in specializeResetT for refc
#25207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
importc obj with nimZeroMemimportc obj with nimZeroMem in specializeResetT for refc
|
pre-existing CI failures: it seems that |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
|
narimiran
pushed a commit
that referenced
this pull request
Oct 7, 2025
…alizeResetT` for `refc` (#25207) fixes #25205 fixes #14873 ```nim type SysLockObj {.importc: "pthread_mutex_t", pure, final, header: """#include <sys/types.h> #include <pthread.h>""", byref.} = object when defined(linux) and defined(amd64): abi: array[40 div sizeof(clong), clong] ``` Before this PR, in refc, `resetLoc` generates field assignments for each fields of `importc` object. But the field `abi` is not a genuine field, which doesn't exits in the struct. We could use `zeroMem` to reset the memory if not leave it alone (cherry picked from commit 02609f1)
narimiran
pushed a commit
that referenced
this pull request
Oct 8, 2025
…alizeResetT` for `refc` (#25207) fixes #25205 fixes #14873 ```nim type SysLockObj {.importc: "pthread_mutex_t", pure, final, header: """#include <sys/types.h> #include <pthread.h>""", byref.} = object when defined(linux) and defined(amd64): abi: array[40 div sizeof(clong), clong] ``` Before this PR, in refc, `resetLoc` generates field assignments for each fields of `importc` object. But the field `abi` is not a genuine field, which doesn't exits in the struct. We could use `zeroMem` to reset the memory if not leave it alone (cherry picked from commit 02609f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25205
fixes #14873
Before this PR, in refc,
resetLocgenerates field assignments for each fields ofimportcobject. But the fieldabiis not a genuine field, which doesn't exits in the struct. We could usezeroMemto reset the memory if not leave it alone