Skip to content

fixes #25262; proc v[T: typedesc]() = discard / v[0]() compiles with values #25382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ringabout wants to merge 2 commits into
base: devel
Choose a base branch
from
+7 −2
Draft

fixes #25262; proc v[T: typedesc]() = discard / v[0]() compiles with values #25382

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
292531b
fixes #25262; proc v[T: typedesc]() = discard / v[0]() compiles with …
ringabout Dec 22, 2025
d6fbe9b
Update sigmatch.nim
ringabout Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/sigmatch.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,9 @@ proc matchGenericParam(m: var TCandidate, formal: PType, n: PNode) =
arg = newTypeS(tyStatic, m.c, son = evaluated.typ)
arg.n = evaluated
elif formalBase.kind == tyTypeDesc:
if arg.kind != tyTypeDesc:
if arg.kind != tyTypeDesc and
n.kind == nkSym and n.sym.kind == skType:
Copy link
Member

@Araq Araq Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A type could also be seq[int]; types are more complex than "it's a symbol"...

Copy link
Member Author

@ringabout ringabout Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not these types (seq[int] be passed as typedesc, I didn't find the cases that are not passed as typedesc if not values

# make sure we have a type here
arg = makeTypeDesc(m.c, arg)
else:
arg = arg.skipTypes({tyTypeDesc})
Expand Down
6 changes: 6 additions & 0 deletions tests/errmsgs/t25262.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
discard """
errormsg: '''type mismatch: got <>'''
"""

proc v[T: typedesc]() = discard
v[0]()