Fixes #25340 #25389
Open
Fixes #25340 #25389
+140
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yglukhov
force-pushed
the
fix-25340
branch
4 times, most recently
from
ac20804 to
eece156
Compare
Araq
reviewed
Dec 30, 2025
Araq
reviewed
Dec 31, 2025
| # Check if the aliased types (last elements) have inheritance relationship | ||
| let aLast = roota.last | ||
| let fLast = rootf.last | ||
| if aLast.kind == tyObject and fLast.kind == tyObject and trIsOutParam notin flags: |
Member
There was a problem hiding this comment.
There is no subtype relation between G[T] and G[S] just because there is one between T and S. This is not sound!
Member
Author
There was a problem hiding this comment.
As I understand it aLast and fLast are not T and S, but the implementations of G[T] and G[S], so the behavior seems to be correct? Also I tried to come up with an example that demonstrates the unsound behavior, but could not. Again, I'm not 100% sure, but I don't see the problem here.
Member
Author
|
Fixed isa relation for refs and ptrs too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is mostly AI generated (sans tests), please review carefully.