Skip to content

enables dfa for refc strings #25418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ringabout wants to merge 3 commits into
base: devel
Choose a base branch
from
Draft

enables dfa for refc strings #25418

ringabout wants to merge 3 commits into from

Conversation

@ringabout
Copy link
Member

@ringabout ringabout commented Jan 7, 2026 •
edited
Loading

  • inline =copy since the hook is not really needed
proc makeiter(v: sink string): string =
  result = v

var iter = makeiter("foo")
echo iter

It seems that we need to handle string literals either by copying it when it is passed to the call or when moving it to the target

arnetheduck
arnetheduck reviewed Jan 7, 2026
View reviewed changes
compiler/injectdestructors.nim
template hasDestructorOrAsgn(c: var Con, typ: PType): bool =
# bug #23354; an object type could have a non-trivial assignements when it is passed to a sink parameter
hasDestructor(c, typ) or (c.graph.config.selectedGC in {gcArc, gcOrc, gcAtomicArc} and
hasDestructor(c, typ) or (c.graph.config.selectedGC == gcRefc and typ.kind == tyString) or (c.graph.config.selectedGC in {gcArc, gcOrc, gcAtomicArc} and
Copy link
Contributor

@arnetheduck arnetheduck Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for seq?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arnetheduck arnetheduck arnetheduck left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ringabout @arnetheduck