remove posix dependency from timportedobj
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= The reliance on the `posix` module made test not usable on platforms not supporting the module. The test is reduced in order to not depend on `posix`. Details ======= The test was added as a regression test for a bug with `liftdestructors` (fixed by c877961), where a hook was lifted for imported types. If the imported type contains a field that doesn't actually exist in the imported (this is the case for, e.g., padding), the resulting assignment of those fields would result in a C compiler error. The test is changed in a way such that it's as explicit as possible (no `seq` usage, no reliance on `Stat`).
saem
approved these changes
Jan 31, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The reliance on the
posixmodule made test not usable on platformsnot supporting the module. The test is reduced in order to not depend
on
posix.Details
The test was added as a regression test for a bug with
liftdestructors(fixed byc877961),
where a hook was lifted for imported types. If the imported type
contains a field that doesn't actually exist in the imported type (this
is the case for, e.g., padding), the resulting assignment of those
fields would result in a C compiler error.
The test is changed in a way such that it's as explicit as possible (no
sequsage, no reliance onStat).