sem: replace addr
calls with nkAddr
#1465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In typed AST, address-of operations are now always represented by
nkAddr
trees. This simplifies some compiler logic, makes processingfor typed macros easier, and fixes an effect tracking bug with
addr
.Details
This is effectively a revert of
nim-lang/Nim#10814.
Not turning calls to
mAddr
intonkAddr
was done to prevent theunsafe address semantics from being lost, but those no longer exist.
Lowering the call into an
nkAddr
tree has the benefit that itsimplifies AST analysis and processing, as address-of operation can now
always be detected by
PNode.kind == nkAddr
. Old code for detectingmAddr
magic calls is removed.The effect tracking in
sempass2
had no special case formAddr
calls, thus treating them as normal calls, which led to
addr(x)
beingtreated as an indirect invocation of
x
, whenx
is of proceduraltype. With the
mAddr
call now being lowered earlier, this is nolonger the case.