sem: replace addr calls with nkAddr
#1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that all address-of operations are represented by `nkAddr` trees in typed AST. Previously, the calls stayed in the AST as `mAddr` calls, requiring analysis to also test for those (which not all analysis did consistently).
There are no more `mAddr` calls in typed AST.
Effect tracking not special casing the `mAddr` call led to `addr x` being considered an indirect call of `x`. With `mAddr` calls gone, this is now fixed.
zerbina
added
bug
saem
approved these changes
Oct 18, 2024
Collaborator
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
/merge The I'm giving merging another try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In typed AST, address-of operations are now always represented by
nkAddrtrees. This simplifies some compiler logic, makes processingfor typed macros easier, and fixes an effect tracking bug with
addr.Details
This is effectively a revert of
nim-lang/Nim#10814.
Not turning calls to
mAddrintonkAddrwas done to prevent theunsafe address semantics from being lost, but those no longer exist.
Lowering the call into an
nkAddrtree has the benefit that itsimplifies AST analysis and processing, as address-of operation can now
always be detected by
PNode.kind == nkAddr. Old code for detectingmAddrmagic calls is removed.The effect tracking in
sempass2had no special case formAddrcalls, thus treating them as normal calls, which led to
addr(x)beingtreated as an indirect invocation of
x, whenxis of proceduraltype. With the
mAddrcall now being lowered earlier, this is nolonger the case.