sigmatch: fix missing conversion for varargs containers #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix an internal-only problem with `sigmatch` handling of named parameters in conjunction with `varargs`. Details ======= Unlike for unnamed parameters, the implicit array construction created when using named parameters for passing a single value to a `varargs` parameter was not wrapped in a to-varargs conversion, nor was the type marked as being a varargs container (via the `tfVarargs` flag). This caused no downstream issues so far, as all three code generators handle the necessary run-time conversion themselves, but it's still incorrect.
zerbina
added
bug
saem
approved these changes
Oct 3, 2025
|
/merge |
|
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2025
## Summary Fix an internal-only problem with `sigmatch` handling of named parameters in conjunction with `varargs`. ## Details Unlike for unnamed parameters, the implicit array construction created when using named parameters for passing a single value to a `varargs` parameter was not wrapped in a to-varargs conversion, nor was the type marked as being a varargs container (via the `tfVarargs` flag). This caused no downstream issues so far, as all three code generators handle the necessary run-time conversion themselves, but it's still incorrect.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/merge |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an internal-only problem with
sigmatchhandling of namedparameters in conjunction with
varargs.Details
Unlike for unnamed parameters, the implicit array construction created
when using named parameters for passing a single value to a
varargsparameter was not wrapped in a to-varargs conversion, nor was the type
marked as being a varargs container (via the
tfVarargsflag).This caused no downstream issues so far, as all three code generators
handle the necessary run-time conversion themselves, but it's
still incorrect.