liftdestructors: generate proper isNil
check
#1630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an internal issue with type-bound operator lifting for closure
types.
Details
Instead of a proper
isNil
check, generation of the "not nil" checkfor
closure environments used the pointer expression itself as the
condition expression of an
if
.Since the expression was translated as is and a pointer value is valid
in an
if
condition position in C, this worked, but it's not correctaccording to NimSkull's type system. A proper "not nil" check is
generated now.