tssl: ignore SslError in "close during write" test #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of the test is to verify that closing a SSL socket after a fatal error happened will not cause the action to raise an error. Sometimes this fatal error manifests as `SslError`, which was not handled, causing intermittent failures (on Windows). This commit modifies the test to also ignore `SslError` should that happens, since we are only interested in the `close` statement not raising an error.
|
@alaviss so why the sudden increase in frequency of occurrence, is that because of underlying version changes in the CI system or something? |
|
Seems to me that GH is slowly rolling out OpenSSL 3.x: actions/runner-images#12676 This might be hitting us on upgraded runners. |
saem
approved these changes
Oct 5, 2025
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix intermittent Windows CI failures from an unhandled
SslErrorbeing raised due to abrupt peer disconnection in
tssl.Details
The goal of the test is to verify that closing an SSL socket after a
fatal error happens will not cause the action to raise an error.
Sometimes this fatal error manifests as
SslError, which was nothandled, causing intermittent failures (on Windows).
This commit modifies the test to also ignore
SslErrorshould thathappen, since we are only interested in the
closestatement notraising an error.