don't unnecessarily register closures with the cycle collector #1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of all closures, only register those that contain potentially
cycle-introducing indirections as potential cycle roots, reducing
pressure on the cycle collector.
Details
While they don't need to be, the generated closure environment object
types were all marked as inheritable. Since the "potential cycle root"
detection treats non-final object types and object types containing
ref
s to non-final objects as potential cycle roots, this led to allnon-cyclic closure environments being candidates for being scanned by
the cycle collector.
Closure environment object types are now marked as final.