semTry sends the whole branch for discard check
#1649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`discardCheck` was updated to appropriately jump to the true last exprerssion, which is not always the last child of the node.
saem
added
bug
saem
changed the title
semTry hands the whole branch for discard checksemTry sends the whole branch for discard check
|
This fix is no longer valid, or might not have ever been. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
discardCheckwas updated to appropriately jump to the true last exprerssion, which is not always the last child of the node.semTrynow appropriately sends the whole branch todiscardCheckto ensure that it's properly traversed and checked for missing discards.Notes for Reviewers