tools: added a port of dust
#979
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clyybber
reviewed
Oct 19, 2023
zerbina
reviewed
Oct 19, 2023
tools/dust/pass.nim
Outdated
| # yield the next available permutation (once) | ||
| result = pop(remains) | ||
| assert result.kind == nkStmtList | ||
| c.ignore = true |
There was a problem hiding this comment.
I'm not entirely sure, but since the process procedure is called for every fragment, wouldn't this mean that everything beyond and including the first declarative statement would be thrown away?
There was a problem hiding this comment.
yeah, seeing as this code seems to be unused, it looks to be an incomplete implementation.
also there is a bug when it comes to debugging types... sigh
added to to `tools` build in `koch`
Co-authored-by: Clyybber <[email protected]>
Co-authored-by: zerbina <[email protected]>
Co-authored-by: zerbina <[email protected]>
Co-authored-by: zerbina <[email protected]>
Co-authored-by: zerbina <[email protected]>
saem
force-pushed
the
saem-tool-dust-port
branch
from
2a5cb71 to
79b0995
Compare
the problem is that right now we generate more and more errors over time, so the minimization process diverges, rather than converging.
right now there is a bug in `semcall.semResolvedCall` where a `tyError` from a faux match doesn't have an error and is being wrapped I'm guessing this will require removing a bunch of unwrapping logic to fix, but not quite sure.
Wrapping nodes is no longer necesssary as they're reported immediately. This was resulting in attempting to wrap nodes that no longer contain errors but resulted in them.
saem
commented
Oct 13, 2025
Comment on lines
+162
to
+163
| #excludeAllNotes(result, hintConf) | ||
| #excludeAllNotes(result, hintLineTooLong) |
|
Dust now works and successfully reduces the broken code in Another thing that will likely help a fair bit is a breadth first search and early elimination of the search space, but I'm not sure how to implement that (besides the breadth first) just yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dustis an automatic test case minimizer written by @disruptekDetails
Notes for Reviewers
discardCheckfix