Skip to content

[606] Fix: Incorrect imports in HomeScreenTest and MockUtil in Sample Compose androidTest #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[606] Fix: Incorrect imports in HomeScreenTest and MockUtil in Sample Compose androidTest #607

wants to merge 2 commits into from

Conversation

kaungkhantsoe
Copy link
Contributor

@kaungkhantsoe kaungkhantsoe commented Mar 10, 2025 •
edited
Loading

#606

What happened 👀

  • Import correct model in HomeScreenTest and MockUtil
  • Fix test fail error by merging /META-INF/LICENSE.md and /META-INF/LICENSE-notice.md
  • Remove redundant imports

Insight 📝

  • We need to use mockk-android for UI Test. Ref
  • We need to add debugImplementation(libs.test.compose.ui.manifest) for androidTest or it will throw Unable to resolve activity for Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] error. Reference

Proof Of Work 📹

ScreenRecording.mp4

@kaungkhantsoe kaungkhantsoe self-assigned this Mar 10, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kaungkhantsoe kaungkhantsoe changed the title [606] Fix incorrect imports in homescreentest and mockutil [606] Fix: Incorrect imports in HomeScreenTest and MockUtil in Sample Compose androidTest Mar 10, 2025
@kaungkhantsoe kaungkhantsoe force-pushed the chore/603-update-to-use-material-3-library-instead-of-old-material-library branch from e4bc1db to ce96d87 Compare March 11, 2025 07:20
@kaungkhantsoe kaungkhantsoe force-pushed the bug/606-fix-incorrect-imports-in-homescreentest-and-mockutil branch from 0553ea8 to 55e73e6 Compare March 11, 2025 07:21
@ryan-conway ryan-conway added this to the 3.32.0 milestone Mar 11, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

9 Warnings
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ template-compose/gradle/libs.versions.toml#L10 - A newer version of androidx.compose:compose-bom than 2025.02.00 is available: 2025.06.00
⚠️ template-compose/gradle/libs.versions.toml#L12 - A newer version of androidx.navigation:navigation-compose than 2.5.3 is available: 2.9.0
⚠️ template-compose/gradle/libs.versions.toml#L13 - A newer version of androidx.core:core-ktx than 1.15.0 is available: 1.16.0
⚠️ template-compose/gradle/libs.versions.toml#L14 - A newer version of androidx.datastore:datastore-preferences than 1.1.3 is available: 1.1.7
⚠️ template-compose/gradle/libs.versions.toml#L16 - A newer version of com.android.application than 8.8.2 is available: 8.10.1
⚠️ template-compose/gradle/libs.versions.toml#L16 - A newer version of com.android.library than 8.8.2 is available: 8.10.1
⚠️ template-compose/gradle/libs.versions.toml#L26 - A newer version of androidx.lifecycle:lifecycle-runtime-compose than 2.8.7 is available: 2.9.1
⚠️ template-compose/gradle/libs.versions.toml#L26 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.8.7 is available: 2.9.1

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.12%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

HomeScreenTest.kt
HomeScreenTest.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
MockUtil.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
build.gradle.kts
libs.versions.toml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@kaungkhantsoe kaungkhantsoe marked this pull request as ready for review March 11, 2025 09:29
@ryan-conway ryan-conway requested a review from Copilot June 6, 2025 02:57
Copilot
Copilot AI reviewed Jun 6, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes incorrect import paths in HomeScreenTest and MockUtil and updates dependency versions/configurations to resolve test failures and ensure proper UI test setup.

  • Corrects import paths for use cases in androidTest.
  • Updates dependency versions including mockk, test rules, and test-compose-ui.
  • Adjusts packaging configuration for merging license files.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sample-compose/gradle/libs.versions.toml Upgraded dependency versions and added test-mockk-android and test-compose-ui-manifest entries.
sample-compose/domain/src/test/java/co/nimblehq/sample/compose/domain/usecases/UpdateFirstTimeLaunchPreferencesUseCaseTest.kt Removed unused experimental coroutine and assert imports.
sample-compose/domain/src/test/java/co/nimblehq/sample/compose/domain/usecases/IsFirstTimeLaunchPreferencesUseCaseTest.kt Removed unused experimental coroutine and assert imports.
sample-compose/app/src/test/java/co/nimblehq/sample/compose/ui/screens/main/home/HomeScreenTest.kt Removed redundant testing imports.
sample-compose/app/src/androidTest/java/co/nimblehq/sample/compose/ui/screens/main/home/HomeScreenTest.kt Updated usecase import paths to the correct package.
sample-compose/app/src/androidTest/java/co/nimblehq/sample/compose/test/MockUtil.kt Corrected import path from domain.model.Model to domain.models.Model.
sample-compose/app/build.gradle.kts Modified packaging block and updated testing dependency configurations to align with UI test requirements.

ryan-conway
ryan-conway reviewed Jun 6, 2025
View reviewed changes
Copy link
Collaborator

@ryan-conway ryan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM 👍🏻

...e/app/src/androidTest/java/co/nimblehq/sample/compose/ui/screens/main/home/HomeScreenTest.kt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests fail to run on my end, not sure if it's an existing issue though 🤔

Base automatically changed from chore/603-update-to-use-material-3-library-instead-of-old-material-library to develop June 6, 2025 03:41
@ryan-conway ryan-conway temporarily deployed to template-compose June 6, 2025 03:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-conway ryan-conway ryan-conway left review comments

Copilot code review Copilot Copilot left review comments

@chornerman chornerman chornerman approved these changes

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@eeeeaa eeeeaa Awaiting requested review from eeeeaa eeeeaa is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn is a code owner

@Johnsonmaung Johnsonmaung Awaiting requested review from Johnsonmaung Johnsonmaung is a code owner

@luongvo luongvo Awaiting requested review from luongvo luongvo is a code owner

@manh-t manh-t Awaiting requested review from manh-t manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@RkNaing RkNaing Awaiting requested review from RkNaing RkNaing is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee is a code owner

@thawzintoe-ptut thawzintoe-ptut Awaiting requested review from thawzintoe-ptut thawzintoe-ptut is a code owner

@toby-thanathip toby-thanathip Awaiting requested review from toby-thanathip toby-thanathip is a code owner

@win-than-htike win-than-htike Awaiting requested review from win-than-htike win-than-htike is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@kaungkhantsoe kaungkhantsoe

Labels
priority : normal type : bug
Projects
None yet
Milestone
3.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kaungkhantsoe @chornerman @ryan-conway