Remove nimiq-genesis as dependency for test-log #3266
Merged
+5
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
force-pushed
the
viquezcl/test-log
branch
2 times, most recently
from
2bdeb23 to
b748185
Compare
|
I think you need to remove |
viquezclaudio
force-pushed
the
viquezcl/test-log
branch
from
b748185 to
eecfc8d
Compare
sisou
approved these changes
Feb 4, 2025
viquezclaudio
force-pushed
the
viquezcl/test-log
branch
from
eecfc8d to
6f1cd60
Compare
jsdanielh
reviewed
Feb 4, 2025
primitives/src/policy.rs
Outdated
| @@ -659,7 +659,8 @@ pub const TEST_POLICY: Policy = Policy { | |||
| batches_per_epoch: 4, | |||
| state_chunks_max_size: 3, | |||
| transaction_validity_window: 2, | |||
| genesis_block_number: 0, | |||
| // This number should match the one that is defined in the unittest genesis file | |||
There was a problem hiding this comment.
Suggested change
| // This number should match the one that is defined in the unittest genesis file | |
| // This number should match the one that is defined in the `unit` network genesis file which is the genesis used for unit testing |
viquezclaudio
force-pushed
the
viquezcl/test-log
branch
from
6f1cd60 to
562d7de
Compare
hrxi
approved these changes
Feb 5, 2025
hrxi
force-pushed
the
viquezcl/test-log
branch
from
562d7de to
ea5f678
Compare
|
Rebased for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2558
...
This fixes #2558 .
Pull request checklist
clippyandrustfmtwarnings.