Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return allow header #1633

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

return allow header #1633

wants to merge 11 commits into from

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Feb 3, 2024 •
edited
Loading

This PR addresses #993

Proposed changes

  • Return allow header in all responses
  • Add test with HEAD HTTP call

@geeksilva97
Copy link
Contributor Author

geeksilva97 commented Feb 3, 2024 •
edited
Loading

It is in progress, I am following the suggestion made in an earlier PR

@geeksilva97 geeksilva97 marked this pull request as ready for review February 4, 2024 14:07
@geeksilva97
Copy link
Contributor Author

geeksilva97 commented Feb 4, 2024 •
edited
Loading

Sup @essen . Could please you share your thoughts? Thanks.

essen
essen reviewed Feb 5, 2024
View reviewed changes
src/cowboy_rest.erl Outdated Show resolved Hide resolved
@geeksilva97 geeksilva97 requested a review from essen February 6, 2024 13:39
@geeksilva97
Copy link
Contributor Author

@essen could you look into this PR one more time when you get a chance? Thanks.

@geeksilva97
Copy link
Contributor Author

@essen could you look into this PR one more time when you get a chance? Thanks.

👀

essen
essen reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@essen essen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't ping repeatedly I always come back eventually.

src/cowboy_rest.erl Show resolved Hide resolved
src/cowboy_rest.erl Show resolved Hide resolved
@geeksilva97 geeksilva97 requested a review from essen March 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@essen essen Awaiting requested review from essen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geeksilva97 @essen