Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Calculate bold mask and dummy scans in transform-only runs #3428

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Member

This builds on #3427 to add a couple final things to the transform-only workflow:

fmriprep $BIDS $OUT participant --derivatives fmriprep=$MINIMAL

BOLD masks were not getting generated from the boldref and dummy scans were not being estimated.

This PR factors out the validation and dummy scan detection from init_raw_boldref_wf and uses the full workflow in fit mode and the subworkflow in transform mode.

Will rebase after #3427 is merged. Can compare now with: c28a615...6c78e54

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.99%. Comparing base (8c58b70) to head (fdbf0f1).

Files with missing lines Patch % Lines
fmriprep/workflows/bold/reference.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3428      +/-   ##
==========================================
+ Coverage   72.92%   72.99%   +0.06%     
==========================================
  Files          57       57              
  Lines        4358     4369      +11     
  Branches      547      548       +1     
==========================================
+ Hits         3178     3189      +11     
  Misses       1064     1064              
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the fix/missing-boldmask branch from 6c78e54 to fdd750b Compare February 11, 2025 16:09
@effigies effigies force-pushed the fix/missing-boldmask branch from fdd750b to fdbf0f1 Compare February 12, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant