Skip to content

feat(cli): Remove CLI flags with expired deprecation periods #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

effigies
Copy link
Member

Pretty straightforward. We said we'd remove these things, and now they're removed. It's been a full year and two minor versions with the deprecation warnings.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (5566157) to head (3da2842).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3445      +/-   ##
==========================================
- Coverage   72.96%   72.96%   -0.01%     
==========================================
  Files          57       57              
  Lines        4439     4431       -8     
  Branches      572      571       -1     
==========================================
- Hits         3239     3233       -6     
+ Misses       1075     1073       -2     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies merged commit b4edde2 into nipreps:master Mar 24, 2025
21 checks passed
@effigies effigies deleted the cli/remove-deprecated-flags branch March 24, 2025 17:47
effigies added a commit that referenced this pull request Mar 25, 2025
25.0.0 (March 25, 2025)

New feature release in the 25.0.x series.

This release substantially improves support for pre-computed derivatives.
Previous releases would miss some derivatives and rerun the computations.
Note that derivatives from previous versions will be accepted,
so it should not be necessary to recompute derivatives from previous versions.
The recommended command line is::

    fmriprep BIDS_DIR OUT_DIR participant --derivatives fmriprep=PRECOMP_DIR

Note that multiple derivatives can be specified, for example::

    fmriprep BIDS_DIR OUT_DIR participant \
      anat=PRECOMPUTED_ANATOMICAL_DIR \
      func=PRECOMPUTED_FUNCTIONAL_DIR

When the same file is found in multiple derivatives, the last one found takes precedence.

Additionally, `--force-*` flags have been consolidated into a single
`--force` flag that can take multiple, space-separated arguments.

Structural processing changes
-----------------------------
We now output white, pial and midthickness fsLR meshes on the subject surface.
Look for `sub-<subject>_hemi-<L|R>_space-fsLR_*_<surf>.surf.gii` files.

Brain extraction has been modified slightly to more closely match the
`antsBrainExtraction.sh` workflow distributed by ANTs.
The impact should be minimal, but in rare cases this fixes a crash.

Fieldmap processing changes
---------------------------
SyN-SDC fieldmap filtering is now single-level, following the improvements
for gradient-echo fieldmaps in 24.1.

Jacobian-weighting during fieldmap unwarping is now on by default *only*
for PEPolar fieldmaps.
To enable for other fieldmap types, use `--force fieldmap-jacobian`.

All merged pull requests
------------------------

* FIX: Detect and apply precomputed fieldmaps (#3439)
* FIX: Calculate bold mask and dummy scans in transform-only runs (#3428)
* FIX: Use consistent skull-stripping pre- and post- SDC (#3415)
* FIX: Use removeprefix instead of lstrip or ternary operator (#3409)
* FIX: Listify sessions when generating reports (#3408)
* FIX: Ensure fieldmap is resampled correctly in report (#3387)
* FIX: Stop excluding FS minc_modify_header used during fallback registration (#3372)
* FIX: Repair and test query for precalculated baseline/boldref files (#3370)
* FIX: Repair search for precomputed transforms (#3369)
* ENH: Enable Jacobians only for PEPOLAR by default, allow forcing (#3443)
* ENH: Create `--force` flag that accepts a list, replacing individual `--force-*` flags (#3442)
* ENH: Output fsLR meshes on subject surfaces (#3411)
* ENH: Flexibilize "sophisticated" pepolar to allow monomodal execution (#3393)
* ENH: Update FSL packages for reported bug fixes (#3374)
* RF: Calculate RMSD from motion transforms (#3427)
* RF: Reconstruct motion confounds from minimal derivatives (#3424)
* RF: Replace deprecated pkgutil.find_loader (#3384)
* RF: Upgrade nitransforms and remove workarounds (#3378)
* DOC: Fix xfm extension in the outputs docs (#3435)
* DOC: Mention fMRIPost-AROMA in parser documentation (#3356)
* MNT: Remove CLI flags with expired deprecation periods (#3445)
* MNT: Update pinned environment (#3440)
* MNT: Bump pins, update RTD config (#3425)
* MNT: Declare linux/amd64 platform during Docker build (#3422)
* MNT: Bump astral-sh/setup-uv from 4 to 5 (#3417)
* MNT: Test support for Python 3.13 (#3416)
* MNT: Install Workbench CLI via conda (#3410)
* MNT: Update minimum dependencies, test with tox-uv (#3412)
* MNT: Install c3d through conda (#3382)
* CI: Fetch tags and 200 commits to support describe (#3381)
* CI: Build docker images in GHA, store cache inline and push to GHCR (#3380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant