-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add minimal type annotations and run mypy in CI #1115
Conversation
Codecov ReportBase: 92.38% // Head: 92.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 97 97
Lines 12250 12250
Branches 2525 2525
=======================================
Hits 11317 11317
Misses 613 613
Partials 320 320 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This comment was marked as resolved.
This comment was marked as resolved.
73a443b
to
7cbc4d3
Compare
7cbc4d3
to
5cded22
Compare
bf14770
to
83aa395
Compare
If anybody's feeling typish, I would appreciate a review here. |
73da8b0
to
e5b6a66
Compare
I plan to merge this in the morning. If someone wants to review first but hasn't found time, let me know. |
e5b6a66
to
7970907
Compare
7970907
to
85f4cb4
Compare
This is great. Thanks, @effigies! |
I'm still getting |
Happy to contribute, if you do. |
Please do! |
Fernando, I went ahead and opened #1196. |
This PR aims to get us started down the path of type annotations (#1109) by getting to a minimal working
mypy
check.These annotations are not intended to be comprehensive, but resolved mypy errors in what seemed the most correct and succinct way.
Thanks to @simkarwin's #1152 I've learned that we can use
from __future__ import annotations
to use Python 3.10-style annotations in a code-base that supports Python 3.7, which is quite nice.I've shielded the
tests/
directories from type checking for now. Resolving issues there will probably help stress test our annotations, but it's a bit much for my current attention span.