Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading freesurfer stats files correctly #1152
base: master
Are you sure you want to change the base?
Reading freesurfer stats files correctly #1152
Changes from all commits
dfed1e3
e0ea23d
84d6e04
8880a1a
97107b7
c3c3e04
02334f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to have example code, it needs to run. We could drop an example file in
nibabel/tests/data/
and access it withCheck warning on line 639 in nibabel/freesurfer/io.py
Codecov / codecov/patch
nibabel/freesurfer/io.py#L637-L639
Check warning on line 664 in nibabel/freesurfer/io.py
Codecov / codecov/patch
nibabel/freesurfer/io.py#L663-L664
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're no longer returning column names. I think you can use numpy.lib.recfunctions.join_by to do what you want.
I would also use the following pattern for doctests:
Check warning on line 667 in nibabel/freesurfer/io.py
Codecov / codecov/patch
nibabel/freesurfer/io.py#L667