-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Apply ruff rules (RUF) #1372
Open
DimitriPapadopoulos
wants to merge
6
commits into
nipy:master
Choose a base branch
from
DimitriPapadopoulos:RUF
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1372 +/- ##
=========================================
Coverage 95.37% 95.37%
=========================================
Files 207 207
Lines 29652 29651 -1
Branches 4988 3054 -1934
=========================================
+ Hits 28280 28281 +1
- Misses 932 933 +1
+ Partials 440 437 -3 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos
force-pushed
the
RUF
branch
from
October 8, 2024 07:25
2a5e7d9
to
3ecea06
Compare
effigies
reviewed
Oct 8, 2024
effigies
reviewed
Oct 8, 2024
effigies
reviewed
Oct 8, 2024
effigies
reviewed
Oct 8, 2024
DimitriPapadopoulos
force-pushed
the
RUF
branch
3 times, most recently
from
October 9, 2024 07:43
9b69ecb
to
c08a1c4
Compare
DimitriPapadopoulos
force-pushed
the
RUF
branch
from
October 9, 2024 07:44
c08a1c4
to
58ac7c6
Compare
effigies
reviewed
Oct 9, 2024
DimitriPapadopoulos
force-pushed
the
RUF
branch
4 times, most recently
from
October 9, 2024 20:11
d8c54d5
to
a327e4a
Compare
RUF012 Mutable class attributes should be annotated with `typing.ClassVar` Co-authored-by: Chris Markiewicz <[email protected]>
RUF017 Avoid quadratic list summation
RUF021 Parenthesize `a and b` expressions when chaining `and` and `or` together, to make the precedence clear Co-authored-by: Chris Markiewicz <[email protected]>
RUF023 `__slots__` is not sorted
RUF031 Avoid parentheses for tuples in subscripts.
Co-authored-by: Chris Markiewicz <[email protected]>
DimitriPapadopoulos
force-pushed
the
RUF
branch
from
October 9, 2024 20:16
a327e4a
to
50a7fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.