FIX: Restore access to private attr Nifti1Extension._content #1378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-1336 reused the private attribute
ext._content
to exclusively refer to thebytes
representation of the extension contents. This neglected that subclasses might depend on this implementation detail.Let's be nice to people and rename the attribute to
_raw
and provide a_content
property that callsself.get_content()
.Also adds a test to ensure that multiple accesses continue to work as expected.