Skip to content

ENH: X5 read/write support of TransformChain #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 20, 2025

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Jul 20, 2025

Summary

  • Facilitates the reading of X5 transforms by adding a from_x5() function in the nitransforms.linear and nitransforms.nonlinear modules.
  • Reading and writing of transform chains in X5 files, ensuring X5 files do not contain duplicated transforms.
  • Ensures all individual transforms implement __eq__().

100% coverage of the patch.

Copy link

codecov bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (fc6fbbd) to head (73f3db1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   95.09%   95.24%   +0.14%     
==========================================
  Files          16       16              
  Lines        1918     1976      +58     
  Branches      251      266      +15     
==========================================
+ Hits         1824     1882      +58     
  Misses         75       75              
  Partials       19       19              
Flag Coverage Δ
unittests 95.06% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oesteban oesteban changed the title Implement TransformChain X5 read/write ENH: X5 read/write support of TransformChain Jul 20, 2025
@oesteban oesteban force-pushed the codex/add-support-for-x5-transform-chains branch 2 times, most recently from 50b2b0a to 6bc2bc1 Compare July 20, 2025 17:46
@oesteban oesteban force-pushed the codex/add-support-for-x5-transform-chains branch 3 times, most recently from f97d8b8 to 8ced1ac Compare July 20, 2025 20:19
@oesteban oesteban force-pushed the codex/add-support-for-x5-transform-chains branch from 8ced1ac to 73f3db1 Compare July 20, 2025 22:03
@oesteban oesteban merged commit a03c51f into master Jul 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant