Fix for git localized messages issue, and also fixes "gc is already running" message#277
Fix for git localized messages issue, and also fixes "gc is already running" message#277denixx wants to merge 1 commit intonirvdrum:masterfrom
Conversation
|
I've publicly stated that the project was stable and feature complete. This was further driven by the upstream work on git-svn having stagnated or stabilized as well. Most PRs submitted here break compatibility or only work on one of the supported platforms. Nearly all the bugs reported really are issues upstream in git-svn. It's extremely time intensive verifying the PR does what it's supposed to. To test this one, I'd need a system not using English. Forcing the en_US locale won't work on all systems, so that needs to be looked at. If the messages from git have changed, I have to look in which version and make sure that Ubuntu LTS works with that version. We do have GitHub Actions available now. If you want to help set up a new CI system, I'd be happy to help and maybe we can get automated updates on PRs in terms of failed checks. Without that, I don't think you appreciate how much time it takes me to verify PRs, especially when the author hasn't provided the necessary background info. Call it abandoned if you like, but to me the project met its stated design goals and works on a wide range of git versions and platforms. That said, if this really is a bug in svn2git and not some system environment issue or a bug in git-svn, then I'd be happy to merge it, pending the platform compatibility verification. Whenever I request this info, I get no help, just the expectation that I should do it in my apparently copious amount of free time. |
|
Thanks a lot for your comprehensive answer. Yeah I totally understand that this fix is not only about the GC thread safety and ensuring the process finished, and testing the locale functionality takes more time to test. And I haven't seen the project statement. No offense intended :) |
|
Hi, Kevin! |
|
@jgubo-mct You welcome, Johannes. I’m glad it is still useful. :) |
No description provided.