Skip to content

Commit

Permalink
get rid of html minifier
Browse files Browse the repository at this point in the history
- REDoS vulnerability - GHSA-pfq8-rq6v-vf5m
  • Loading branch information
nisrulz committed Aug 20, 2024
1 parent 9596fbb commit fca65dc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20 # has to be
cache: 'npm'
cache: 'npx'

- name: Install all CLI tools
run: npm install -g @tokilabs/pug3-cli sass js-yaml firebase-tools svgo png-minify uglifycss uglify-js html-minifier purgecss
run: npx install -g @tokilabs/pug3-cli sass js-yaml firebase-tools svgo png-minify uglifycss uglify-js purgecss

- name: Render the website from templates
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20 # has to be LTS
cache: 'npm'
cache: 'npx'

- name: Install all CLI tools
run: npm install -g @tokilabs/pug3-cli sass js-yaml firebase-tools svgo png-minify uglifycss uglify-js html-minifier purgecss
run: npx install -g @tokilabs/pug3-cli sass js-yaml firebase-tools svgo png-minify uglifycss uglify-js purgecss

- name: Render the website from templates
run: |
Expand Down
6 changes: 0 additions & 6 deletions render.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,3 @@ uglifyjs src/js/main.js --output public/js/main.min.js
uglifyjs src/js/utils.js --output public/js/utils.min.js
uglifyjs src/js/flycricket.js --output public/js/flycricket.min.js
echo " ✅ STEP 6: Minify JS"

echo ""
html-minifier public/index.html \
--collapse-whitespace --keep-closing-slash --remove-comments \
--output public/index.html
echo " ✅ STEP 7: Minify HTML"

0 comments on commit fca65dc

Please sign in to comment.