Skip to content

Commit

Permalink
github action: use !cancelled() instead of success() || failure()
Browse files Browse the repository at this point in the history
Signed-off-by: Jean Privat <[email protected]>
  • Loading branch information
privat committed Jun 27, 2024
1 parent 1c2970b commit cd7425f
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions .github/workflows/makefile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ jobs:
- uses: actions/checkout@v4
- run: misc/jenkins/ensuregit.sh
- run: misc/jenkins/checkwhitespaces.sh
if: success() || failure()
if: !cancelled()
- run: misc/jenkins/checklicense.sh
if: success() || failure()
if: !cancelled()
- run: misc/jenkins/checksignedoffby.sh
if: success() || failure()
if: !cancelled()

tests-some:
runs-on: ubuntu-24.04
Expand Down Expand Up @@ -67,17 +67,17 @@ jobs:
- run: cd tests && ./search_tests_git.sh origin/master HEAD > list
- run: cd tests && ./tests.sh --engine ${{ matrix.engine }} `cat list`
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: 'tests/*.xml'
name: tests-some-${{ matrix.engine }}
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: 'tests/out'
name: tests-some-${{ matrix.engine }}-res
- uses: EnricoMi/publish-unit-test-result-action@v2
if: success() || failure()
if: !cancelled()
with:
files: "tests/*.xml"
comment_mode: off
Expand Down Expand Up @@ -113,17 +113,17 @@ jobs:
- name: Run tests
run: cd tests && ./testfull.sh --engine ${{ matrix.engine }}
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: 'tests/*.xml'
name: tests-full-${{ matrix.engine }}
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: 'tests/out'
name: tests-full-${{ matrix.engine }}-res
- uses: EnricoMi/publish-unit-test-result-action@v2
if: success() || failure()
if: !cancelled()
with:
files: "tests/*.xml"
comment_mode: off
Expand Down Expand Up @@ -153,12 +153,12 @@ jobs:
- run: chmod +x bin/*
- run: make nitunit-some
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: '*.xml'
name: nitunit-some
- uses: EnricoMi/publish-unit-test-result-action@v2
if: success() || failure()
if: !cancelled()
with:
files: "*.xml"
comment_mode: off
Expand Down Expand Up @@ -188,12 +188,12 @@ jobs:
- run: chmod +x bin/*
- run: make nitunit-full
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: '*.xml'
name: nitunit-full
- uses: EnricoMi/publish-unit-test-result-action@v2
if: success() || failure()
if: !cancelled()
with:
files: "*.xml"
comment_mode: off
Expand All @@ -210,12 +210,12 @@ jobs:
- run: chmod +x bin/*
- run: 'PATH=$PWD/bin:$PATH make test-contrib'
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: '*.xml'
name: test-contrib
- uses: EnricoMi/publish-unit-test-result-action@v2
if: success() || failure()
if: !cancelled()
with:
files: "*.xml"
comment_mode: off
Expand All @@ -240,7 +240,7 @@ jobs:
- run: chmod +x bin/*
- run: 'PATH=$PWD/bin:$PATH make bench-fast'
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: |-
benchmarks/*.dat
Expand All @@ -260,7 +260,7 @@ jobs:
- run: chmod +x bin/*
- run: make valgrind
- uses: actions/upload-artifact@v4
if: success() || failure()
if: !cancelled()
with:
path: 'valgrind.out'
name: valgrind
Expand Down

0 comments on commit cd7425f

Please sign in to comment.