Skip to content

fix: wrap /bin/sh to load environment #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2024
Merged

fix: wrap /bin/sh to load environment #561

merged 1 commit into from
Oct 5, 2024

Conversation

nzbr
Copy link
Member

@nzbr nzbr commented Oct 4, 2024

Fixes the environment not being available to commands where /bin/sh is called directly. This happens for example when trying to switch into a dev container in a VSCode attached to the WSL distro. Fixes #555

@nzbr nzbr added the bug Something isn't working label Oct 4, 2024
@nzbr nzbr requested review from K900 and SuperSandro2000 October 4, 2024 23:44
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely cursed, but what can you do...

@nzbr nzbr merged commit 5a7c64a into main Oct 5, 2024
24 checks passed
@nzbr nzbr deleted the wrapped-bin-sh branch October 5, 2024 13:19
@nzbr nzbr changed the title shell-wrapper: wrap /bin/sh fix: wrap /bin/sh to load environment Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode-Devcontainer not working
2 participants