-
-
Notifications
You must be signed in to change notification settings - Fork 2k
progs: firefox: *.userChrome may be path or drv #6761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progs: firefox: *.userChrome may be path or drv #6761
Conversation
e11ac94
to
a846d21
Compare
a846d21
to
1eb6ddd
Compare
1eb6ddd
to
37548f8
Compare
37548f8
to
4e03b78
Compare
This allows `programs.firefox.profiles.*.userChrome` to be set to a: derivation, path/path-like string to directory or file, or multiline text to be used as content verbatim. This allows setting, for example(s): ```nix programs.firefox.profiles."jacob.default".userChrome = pkgs.wavefox; programs.firefox.profiles."jacob.default".userChrome = "${pkgs.wavefox}/userChrome.css"; ```
4e03b78
to
920637d
Compare
Removed accidental VS Code workspace change. Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this actually allows me to remove some hacky stuff I had to do with my configuration for installing a theme.
Supported in nix-community/home-manager#6761 We can use the path to also copy the images over to the proper location, as well.
This broke my config, in which I set
The error says that the string doesn't represent an absolute path. It seems to fail while executing |
Oops, thought we had basic tests already.. I'll add some tests and fix it. |
Setting a string for me worked, |
The function seems to get tripped up by a URL, it complains about the first line of this:
|
I have a fix, just finishing up unit tests. |
Description
This allows
programs.firefox.profiles.*.userChrome
to be set to a:derivation, path/path-like string to directory or file, or multiline
text to be used as content verbatim.
This allows setting, for example(s):
Checklist
(Painstakingly) Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
or
nix build --reference-lock-file flake.lock ./tests#test-all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC