blesh: add module #7087
Draft
blesh: add module #7087
+300
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added this patch to the news entry yet until #3238 (comment) (technically #3238 (comment)) is implemented for obvious reasons, alongside some manual testing on my side. |
awwpotato
reviewed
May 20, 2025
Manually imported from a previous merge request at nix-community#3238 by @aiotter. I'll be following up with a few more changes per the previous thread in a few days, but I wanted to test this out in the meantime on my own home-manager configuration. Note that this commit was made via GitHub Codespaces, hence I need to manually unset GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL, alongside using the regular gpg binary instead of gh-gpgsign inside the devcontainer. Signed-off-by: Andrei Jiroh Halili <[email protected]> On-behalf-of: @recaptime-dev <[email protected]>
also fix the missing attribute error on `meta.maintainers` by pulling it via `lib.hm` as a workaround. Signed-off-by: Andrei Jiroh Halili <[email protected]> on-behalf-of: @recaptime-dev <[email protected]>
Context: nix-community#7087 (comment) Signed-off-by: Andrei Jiroh Halili <[email protected]> on-behalf-of: @recaptime-dev <[email protected]
ajhalili2006
force-pushed
the
ajhalili2006/blesh
branch
from
dfc307c to
5aaf4ff
Compare
Catching what I missed on the previous commit (5aaf4ff).
Reformat at will after resolving merge conflicts as I rebase against the main branch to keep things in sync. Signed-off-by: Andrei Jiroh Halili <[email protected]>
Signed-off-by: Andrei Jiroh Halili <[email protected]>
|
Going to do another round of rebasing soon, currently working on other things behind the scenes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another attempt at #3238, although I will probably need help implementing
programs.blesh.attach = "manualthrough conditional statement trickery due to being inexperienced with the rest of Nix language over than the basics (likelet...inkeywords and imports).Checklist
Change is backwards compatible.
Code formatted with
nix fmtor./format.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC