way-displays: support stateful configuration file #7138
Conversation
mightyiam
force-pushed
the
way-displays-stateful
branch
from
77a58f7 to
1d120e7
Compare
mightyiam
force-pushed
the
way-displays-stateful
branch
4 times, most recently
from
e83d47a to
749da99
Compare
| } | ||
| cfg.settings | ||
| ]); | ||
| home.packages = [ cfg.package ]; |
There was a problem hiding this comment.
The package being available in the environment is aligned with the stateful workflow but I think it can be useful for the static case as well so I did not make it conditional.
mightyiam
changed the title
There was a problem hiding this comment.
I guess this could be useful, but see my question about auto-starting the service.
Also, I'm not sure I understand what upside this has compared to just not creating a config file? Wouldn't that have much the same effect? (Except for not starting the service, which I don't understand why you would not want to do.)
mightyiam
force-pushed
the
way-displays-stateful
branch
from
749da99 to
ef8b9f1
Compare
| wayland.windowManager = lib.mapAttrs (name: _: { | ||
| systemd.variables = [ "XDG_VTNR" ]; | ||
| }) options.wayland.windowManager; |
There was a problem hiding this comment.
I don't know if we're allowed to do such a thing but I'm willing to be so bold.
There was a problem hiding this comment.
It can be found in pam_systemd(8). way-displays uses it. The daemon seems to work without it defined, but then the client fails. So for the static configuration workflow it does not seem necessary but for the stateful one it is.
| xdg.configFile."way-displays/cfg.yaml" = mkIf (cfg.settings != null) { | ||
| source = yaml.generate "way-displays-config.yaml" (mergeSets [ | ||
| { | ||
| CALLBACK_CMD = "${pkgs.libnotify}/bin/notify-send \"way-displays \${CALLBACK_LEVEL}\" \"\${CALLBACK_MSG}\""; |
There was a problem hiding this comment.
Losing this sucks. It's like... there should be both a configuration file and a state file.
There was a problem hiding this comment.
that's a request for way-displays I guess
mightyiam
force-pushed
the
way-displays-stateful
branch
from
ef8b9f1 to
7703bc7
Compare
Description
This is good for when displays are not considered part of the home configuration and are instead considered ephemeral.
Great for laptops but I use it for my desktop as well.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@jolars