treewide: remove no-ops (2) #8065
Conversation
| [formatter.deadnix] | ||
| command = "deadnix" | ||
| options = [ "--edit", "--no-lambda-arg", "--no-lambda-pattern-names" ] | ||
| options = [ "--edit" ] |
There was a problem hiding this comment.
There's a reason this was added, though. We've done this before and it broke stuff.
There was a problem hiding this comment.
Ok. The unit tests succeed at least.
There was a problem hiding this comment.
Not seeing anything immediately that looks like it would cause issues. Will take a look a bit more later though to see what we had to remedy after last time. I see a commit that changed how we structured args to prevent deadnix from removing an arg again in a99bddf and the rule change was done in 475d357 to handle certain files that were broken from default rules.
modules/lib/booleans.nix
Outdated
| @@ -1,4 +1,4 @@ | |||
| { lib }: | |||
| { ... }: | |||
There was a problem hiding this comment.
| { ... }: |
| im = config.i18n.inputMethod; | ||
| in | ||
| { | ||
| config = lib.mkIf (im.enable && im.type == "hime") { |
There was a problem hiding this comment.
Does deadnix actually remove top level configs by itself now? Interesting..
There was a problem hiding this comment.
No, I did this manually when I came across it.
| { config, pkgs, ... }: | ||
|
|
There was a problem hiding this comment.
bf893ad Robert Helgesson (2025-07-13 02:53):
tests: re-add module argument
These were removed as part of dead code removal, but they are actually
needed in the integration tests for comparing with the configuration
generated by the installation.
Hunk 1 of 1 @@ -0 +1,2 @@
+{ config, pkgs, ... }:
+
There was a problem hiding this comment.
We could handle these cases with a # deadnix: skip pragma (documented here).
I just tried to check whether the removal of the lambda pattern lets the test fail, but currently, the fails in both cases.
| { config, pkgs, ... }: | ||
|
|
home-manager-ci
bot
requested review from
berbiche,
fufexan and
karaolidis
and removed request for
B1kku and
MunsMan
|
element-desktop.nix 👍 |
11 participants
Description
Inspired by @khaneliman's comment, I lifted all restrictions on
deadnixand formatted the code base accordingly.Also, I removed many redundant
config = { ... }wrappings.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.